[Form] Remove :end-before:, :start-after: as it's not used anymore
#17063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
force-pushed
the
form/directive-not-supported
branch
from
ca21c56 to
efc6c2e
Compare
|
Thank you Maxime. |
|
Isn't the default value now being rendered before the option name? IIRC we rejected several PRs like this in the past as we considered this issue to be something that needed to be fixed in the rst parser that we use. |
|
Ah, I see that @mdoutreluingne had the same thought and fixes this in #17093. |
javiereguiluz
added a commit
that referenced
this pull request
Aug 2, 2022
…treluingne) This PR was merged into the 4.4 branch. Discussion ---------- [Form] Fix typo `choice_translation_domain` option Sorry for my typo. For this PR, I fix my typo for the `choice_translation_domain` option which refers to my old PR #17063 . Actually the `type` and `default` is above option ([see](https://symfony.com/doc/4.4/reference/forms/types/date.html#choice-translation-domain)). Commits ------- 45767ac Fix typo choice_translation_domain option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16466 (I deleted the branch of my old pr accidentally, so I recreate a new PR)
:end-before:,:start-after:directives is not supported by the new ReST parser, so it is displayed in the page:Reviews are welcome! :)